Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-fix /transaction/:txHash endpoint #6689

Closed
wants to merge 5 commits into from

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Dec 20, 2024

Reasoning behind the pull request

  • Fixed the problem related to the wrong hyper block nonce on a transaction that is returned by API

Proposed changes

  • Extended the MiniBlockMetadata structure with extra information about the partial execution
  • This change was needed because some fields from the transaction structure were populated with wrong values

Testing procedure

  • Check if the endpoint /transaction/:hash return the correct value for fields notarizedAtDestinationInMetaNonce, notarizedAtDestinationInMetaHash, hyperblockNonce, and hyperblockHash

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@miiu96 miiu96 self-assigned this Dec 20, 2024
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: a449fcf20b6488b18131d4b4dfca954325100198
  • Current Branch: MX-16368-fix-tx-hyperblock-nonce
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 20122024-125456
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: a449fcf20b6488b18131d4b4dfca954325100198
  • Current Branch: MX-16368-fix-tx-hyperblock-nonce
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 20122024-125536
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: c775f83efe890983390f6f67de5235e32627bbe2
  • Current Branch: MX-16368-fix-tx-hyperblock-nonce
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 20122024-134231
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: c503f6785344102caa724b7fb0ff2762e8b56ec5
  • Current Branch: MX-16368-fix-tx-hyperblock-nonce
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 20122024-135301
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: d51a39bcf6a454d1779cca9d64c6688a4f67106a
  • Current Branch: MX-16368-fix-tx-hyperblock-nonce
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 20122024-150851
  • PYTEST_EXIT_CODE: 1
    🎉 MultiversX CI/CD Workflow Complete!

@miiu96 miiu96 closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant